feat!: update all deps #1963
Merged
feat!: update all deps #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amje
requested review from
IsaevAlexandr,
Arucard89,
korvin89,
kseniya57,
Marginy605 and
ValeraS
as code owners
|
Preview is ready. |
|
Visual Tests Report is ready. |
amje
requested review from
ogonkov,
Raubzeug,
mournfulCoroner,
DakEnviy,
goshander and
Lunory
as code owners
Raubzeug
approved these changes
Nov 27, 2024
Marginy605
approved these changes
Nov 27, 2024
mournfulCoroner
approved these changes
Nov 27, 2024
ogonkov
reviewed
Nov 27, 2024
gulpfile.js
Outdated
| @@ -55,7 +55,7 @@ task('copy-i18n', () => { | |||
| task('styles-global', () => { | |||
| return src(['styles/styles.scss', 'styles/fonts.scss']) | |||
| .pipe( | |||
| sass().on('error', function (error) { | |||
| sass({silenceDeprecations: ['legacy-js-api']}).on('error', function (error) { | |||
There was a problem hiding this comment.
Why not upgrade for latest api? We did it in app-builder already for example
There was a problem hiding this comment.
Upgrade what? This is the issue within the gulp-dart-scss package.
There was a problem hiding this comment.
Instead of gulp-dart-scss we can use gulp-sass package which supports the new sass API.
korvin89
approved these changes
Nov 28, 2024
ValeraS
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.